From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][QEMU] Use a separate device for in-kernel PIT (v2) Date: Tue, 25 Mar 2008 14:37:46 +0200 Message-ID: <47E8F21A.7060102@qumranet.com> References: <1206384899-16502-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sf.net, Hollis Blanchard To: Anthony Liguori Return-path: In-Reply-To: <1206384899-16502-1-git-send-email-aliguori@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > Part of the feedback we received from Fabrice about the KVM patches for QEMU > is that we should create a separate device for the in-kernel APIC to avoid > having lots of if (kvm_enabled()) within the APIC code that were difficult to > understand why there were needed. > > This patch separates the in-kernel PIT into a separate device. It also > introduces some configure logic to only compile in support for the in-kernel > PIT if it's available. > > The result of this is that we now only need a single if (kvm_enabled()) to > determine which device to use. Besides making it more upstream friendly, I > think this makes the code much easier to understand. > > Since v1=>v2, we make sure to use common code for save/restore between > in-kernel pit and in-qemu pit. > > Please separate the code movement and changes into separate patches. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/