public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sf.net, Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [PATCH][QEMU] Use a separate device for in-kernel PIT	(v2)
Date: Tue, 25 Mar 2008 16:44:15 -0500	[thread overview]
Message-ID: <47E9722F.9040407@us.ibm.com> (raw)
In-Reply-To: <47E8F21A.7060102@qumranet.com>

Avi Kivity wrote:
>
> Please separate the code movement and changes into separate patches.

I'm not sure there's a great way to do this that preserves bisectability 
and results in meaningful history.  I could leave the #ifdef's in 
i8254-kvm.c and then have a second patch that removes them.  That 
doesn't seem to be terribly valuable though from a history perspective 
as it still requires a bit of code change to keep things working.  Were 
you thinking of something else?

Regards,

Anthony Liguori



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

  reply	other threads:[~2008-03-25 21:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-24 18:54 [PATCH][QEMU] Use a separate device for in-kernel PIT (v2) Anthony Liguori
2008-03-24 21:08 ` Jerone Young
2008-03-25 12:37 ` Avi Kivity
2008-03-25 21:44   ` Anthony Liguori [this message]
2008-03-26 10:03     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E9722F.9040407@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=avi@qumranet.com \
    --cc=hollisb@us.ibm.com \
    --cc=kvm-devel@lists.sf.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox