From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH][QEMU] Use a separate device for in-kernel PIT (v2) Date: Tue, 25 Mar 2008 16:44:15 -0500 Message-ID: <47E9722F.9040407@us.ibm.com> References: <1206384899-16502-1-git-send-email-aliguori@us.ibm.com> <47E8F21A.7060102@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sf.net, Hollis Blanchard To: Avi Kivity Return-path: In-Reply-To: <47E8F21A.7060102@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Avi Kivity wrote: > > Please separate the code movement and changes into separate patches. I'm not sure there's a great way to do this that preserves bisectability and results in meaningful history. I could leave the #ifdef's in i8254-kvm.c and then have a second patch that removes them. That doesn't seem to be terribly valuable though from a history perspective as it still requires a bit of code change to keep things working. Were you thinking of something else? Regards, Anthony Liguori ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace