From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile Date: Wed, 26 Mar 2008 18:41:56 +0200 Message-ID: <47EA7CD4.8010604@qumranet.com> References: <92ec769968b9bf27d3489e819bf1bbf8@kernel.crashing.org> <1206462789.7284.1.camel@thinkpadL> <47E931A8.9030509@qumranet.com> <1206472172.12682.3.camel@thinkpadL> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-ppc-devel@lists.sourceforge.net, kvm-devel@lists.sourceforge.net To: jyoung5@us.ibm.com Return-path: In-Reply-To: <1206472172.12682.3.camel@thinkpadL> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Jerone Young wrote: > Yeah. This could "potentially" cause hell for users (non developers) > down the road. I'm just going to keep this patch in my queue for myself, > so no one will complain about warnings from my patches anymore. > > I think having a --developer flag to configure could work, but we would > then need separate file for including the CFLAG, this would just clutter > things more. > One other option is to enable -Werror by default, and have a --disable-werror configure flag. It means we'll get better coverage, but the user experience when it breaks will be worse. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace