From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH 2/3] [PATCH] unregister pci device Date: Thu, 27 Mar 2008 08:40:31 -0300 Message-ID: <47EB87AF.6060204@redhat.com> References: <1206565792-19627-1-git-send-email-gcosta@redhat.com> <1206565792-19627-3-git-send-email-gcosta@redhat.com> <47EB51D3.7050800@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Avi Kivity Return-path: In-Reply-To: <47EB51D3.7050800@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Glauber Costa wrote: >> If we fail after we have allocated the pci device, we have >> to get rid of it. Otherwise, a bogus device will be found on >> the bus >> > > Maybe, alter the order so the device is registered last thing. This may > help avoid races with pci passthrough hotplug. > That's the first thing I thought, but it makes things much more complicated. If really deserved, I can try again. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace