Re: [PATCH] KVM: MMU: Fix rmap_remove() race

Avi Kivity
2008-03-26T15:15:20Z

Avi Kivity wrote:
> Andrea notes that freeing the page before flushing the tlb is a race, as the
> guest can sneak in one last write before the tlb is flushed, writing to a
> page that may belong to someone else.
>
> Fix be reversing the order of freeing and flushing the tlb. Since the tlb
> flush is expensive, queue the pages to be freed so we need to flush just once.
>
>

This was missing a conversion of rmap_remove() to rmap_remove_one() in
paging_tmpl.h. I fixed it in my tree.

But, a review would still be appreciated.

--
error compiling committee.c: too many arguments to function