Re: [PATCH] KVM: MMU: Fix rmap_remove() race

Avi Kivity
2008-03-27T13:56:56Z

Andrea Arcangeli wrote:
> On Thu, Mar 27, 2008 at 10:11:42AM +0200, Avi Kivity wrote:
>
>> Erm I don't think this means what you think it means. This is the
>> kernel/user communication area, used to pass exit data to userspace. It's
>> not the memslot vma.
>>
>
> Yep... only the kvm_vm_vm_ops can run gfn_to_page, and I assume that
> was used by the old userland and not relevant anymore (smaps don't
> show it either), or the pages could not be unmapped. So btw, that
> kvm-vm anon inode must be disabled when mmu notifiers are configured
> in to guarantee that access to /dev/kvm won't lead to mlock behavior.
>

That's not good. We need to support the older userspace, for a while yet.

Why is there a problem? IIRC it's just anonymous memory.

--
error compiling committee.c: too many arguments to function