From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <marcelo@kvack.org>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [patch 2/3] QEMU/KVM: add function to handle signals
Date: Thu, 27 Mar 2008 17:57:40 +0200 [thread overview]
Message-ID: <47EBC3F4.6000800@qumranet.com> (raw)
In-Reply-To: <20080327155736.GB8184@dmt>
Marcelo Tosatti wrote:
> On Thu, Mar 27, 2008 at 05:25:20PM +0200, Avi Kivity wrote:
>
>> Marcelo Tosatti wrote:
>>
>>> SIGUSR1 has no handler, and the SIGUSR2 one does nothing useful anymore
>>> (thats also true for SIGIO on tap fd, which runs host_alarm_handler
>>> unnecessarily).
>>>
>>>
>> The sigaction(); sa.sa_handler() stuff was added as a stopgap; do we
>> actually need to run _any_ signal handlers?
>>
>
> Yes, we need to run host_alarm_handler() to set ALARM_EXPIRED, so the
> alarm timer gets rearmed by main_loop_wait. Thats the only one.
>
>
We can call it explicitly. I'm worried about the slirp code. I think I
checked it once but it is sufficiently obfuscated to be worrying.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2008-03-27 15:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 15:09 [patch 0/3] QEMU dedicated IO thread Marcelo Tosatti
2008-03-27 15:09 ` [patch 1/3] QEMU/KVM: separate thread for IO handling Marcelo Tosatti
2008-03-27 15:23 ` Avi Kivity
2008-03-27 15:48 ` Marcelo Tosatti
2008-03-27 15:49 ` Avi Kivity
2008-03-27 15:09 ` [patch 2/3] QEMU/KVM: add function to handle signals Marcelo Tosatti
2008-03-27 15:25 ` Avi Kivity
2008-03-27 15:57 ` Marcelo Tosatti
2008-03-27 15:57 ` Avi Kivity [this message]
2008-03-27 16:55 ` Avi Kivity
2008-03-27 15:09 ` [patch 3/3] QEMU/libkvm: dont create vcpu0 thread Marcelo Tosatti
2008-03-27 15:55 ` Avi Kivity
2008-03-27 15:54 ` [patch 0/3] QEMU dedicated IO thread Avi Kivity
2008-03-27 19:06 ` Avi Kivity
2008-03-27 20:21 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2008-04-02 23:20 [patch 0/3] separate thread for IO handling V3 Marcelo Tosatti
2008-04-02 23:20 ` [patch 2/3] QEMU/KVM: add function to handle signals Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47EBC3F4.6000800@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox