From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: MMU: unify slots_lock usage Date: Sun, 30 Mar 2008 12:43:43 +0300 Message-ID: <47EF60CF.6010504@qumranet.com> References: <20080329231759.GA31065@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Marcelo Tosatti Return-path: In-Reply-To: <20080329231759.GA31065@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > Unify slots_lock acquision around vcpu_run(). This is simpler and less > error-prone. > > Also fix some callsites that were not grabbing the lock properly. > > Please review. > > While I think we could simplify the locking even further (by locking at the caller of __vcpu_run), this is already a huge improvement, so I applied it. Thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace