From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Use QEMU functions to access guest memory for virtio Date: Sun, 30 Mar 2008 13:51:07 +0300 Message-ID: <47EF709B.8000003@qumranet.com> References: <1206481168-7185-1-git-send-email-aliguori@us.ibm.com> <47EA4F2D.5050703@qumranet.com> <47EA5C6F.6060201@us.ibm.com> <47EA5E92.5080004@qumranet.com> <47EEB96A.40703@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sf.net, Aurelien Jarno To: Anthony Liguori Return-path: In-Reply-To: <47EEB96A.40703@codemonkey.ws> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > I converted everything to use offsetof but left the accessors. You need > a fair number of macros to handle the various data sizes and even then, > I think it ends up looking nicer with the macros. See my patch series > on qemu-devel and let me know if you agree/disagree. > > Accessors are fine, I just disliked the open-coded offsets. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace