* Re: [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask for ia64
[not found] <42DFA526FC41B1429CE7279EF83C6BDCFF7EFE@pdsmsx415.ccr.corp.intel.com>
@ 2008-03-30 11:42 ` Avi Kivity
2008-03-31 1:40 ` Zhang, Xiantao
0 siblings, 1 reply; 2+ messages in thread
From: Avi Kivity @ 2008-03-30 11:42 UTC (permalink / raw)
To: Zhang, Xiantao
Cc: Carsten Otte, Luck, Tony, linux-ia64, kvm-ia64-devel, kvm-devel,
Jes Sorensen, virtualization
Zhang, Xiantao wrote:
>
> diff --git a/include/linux/smp.h b/include/linux/smp.h
> index 55232cc..b71820b 100644
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -56,6 +56,9 @@ int smp_call_function(void(*func)(void *info), void
> *info, int retry, int wait);
>
> int smp_call_function_single(int cpuid, void (*func) (void *info), void
> *info,
> int retry, int wait);
> +int smp_call_function_mask(cpumask_t mask,
> + void (*func)(void *), void *info,
> + int wait);
>
>
For all other archs, smp_call_function_mask() is declared in <asm/smp.h>
so please define it there. A separate patch can move the declarations
to <linux/smp.h>, since it makes sense to have just one declaration (and
the uniprocessor version is declared there anyway).
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask for ia64
2008-03-30 11:42 ` [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask for ia64 Avi Kivity
@ 2008-03-31 1:40 ` Zhang, Xiantao
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Xiantao @ 2008-03-31 1:40 UTC (permalink / raw)
To: Avi Kivity
Cc: Luck, Tony, Xu, Anthony, Jes Sorensen, Akio Takebe, kvm-devel,
kvm-ia64-devel, linux-ia64, virtualization, Carsten Otte
Avi Kivity wrote:
> Zhang, Xiantao wrote:
>>
>> diff --git a/include/linux/smp.h b/include/linux/smp.h
>> index 55232cc..b71820b 100644
>> --- a/include/linux/smp.h
>> +++ b/include/linux/smp.h
>> @@ -56,6 +56,9 @@ int smp_call_function(void(*func)(void *info),
>> void *info, int retry, int wait);
>>
>> int smp_call_function_single(int cpuid, void (*func) (void *info),
>> void *info, int retry, int wait);
>> +int smp_call_function_mask(cpumask_t mask,
>> + void (*func)(void *), void *info,
>> + int wait);
>>
>>
>
> For all other archs, smp_call_function_mask() is declared in
> <asm/smp.h> so please define it there. A separate patch can move the
> declarations to <linux/smp.h>, since it makes sense to have just one
> declaration (and the uniprocessor version is declared there anyway).
OK, moved it to asm-ia64/smp.h first, although only x86 arch defined the
interface in current code. :)
Xiantao
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-31 1:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <42DFA526FC41B1429CE7279EF83C6BDCFF7EFE@pdsmsx415.ccr.corp.intel.com>
2008-03-30 11:42 ` [kvm-ia64-devel] [02/17][PATCH] Implement smp_call_function_mask for ia64 Avi Kivity
2008-03-31 1:40 ` Zhang, Xiantao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox