public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	Zdenek Kabelac <zdenek.kabelac@gmail.com>
Subject: Re: [PATCH] prepopulate guest pages after write-protecting
Date: Sat, 05 Apr 2008 00:06:15 +0300	[thread overview]
Message-ID: <47F69847.7090609@qumranet.com> (raw)
In-Reply-To: <20080404175644.GA444@dmt>

Marcelo Tosatti wrote:
> Zdenek reported a bug where a looping "dmsetup status" eventually hangs
> on SMP guests.
>
> The problem is that kvm_mmu_get_page() prepopulates the shadow MMU
> before write protecting the guest page tables. By doing so, it leaves a
> window open where the guest can mark a pte as present while the host has
> shadow cached such pte as "notrap". Accesses to such address will fault
> in the guest without the host having a chance to fix the situation.
>   

Applied, thanks.  Impressive catch.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace

      parent reply	other threads:[~2008-04-04 21:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-04 17:56 [PATCH] prepopulate guest pages after write-protecting Marcelo Tosatti
2008-04-04 19:08 ` Zdenek Kabelac
2008-04-04 21:06 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F69847.7090609@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=mtosatti@redhat.com \
    --cc=zdenek.kabelac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox