From: Avi Kivity <avi@qumranet.com>
To: Carsten Otte <cotte@de.ibm.com>
Cc: sfr@canb.auug.org.au,
"kvm-devel@lists.sourceforge.net"
<kvm-devel@lists.sourceforge.net>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Olaf Schnapper <os@de.ibm.com>
Subject: Re: [PATCH 03/04] kvm-s390: Improve pgste accesses
Date: Sat, 05 Apr 2008 00:08:40 +0300 [thread overview]
Message-ID: <47F698D8.7080808@qumranet.com> (raw)
In-Reply-To: <1207314757.18908.20.camel@cotte.boeblingen.de.ibm.com>
Carsten Otte wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> There is no need to use interlocked updates when the rcp
> lock is held. Therefore the simple bitops variants can be
> used. This should improve performance.
>
> skey = page_get_storage_key(page_to_phys(page));
> if (skey & _PAGE_CHANGED)
> - set_bit(RCP_GC_BIT, pgste);
> + set_bit_simple(RCP_GC_BIT, pgste);
>
This looks whitespace damaged.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
next prev parent reply other threads:[~2008-04-04 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1207314468.18908.12.camel@cotte.boeblingen.de.ibm.com>
2008-04-04 13:12 ` [PATCH 01/04] kvm-s390: Some codingstyle issues Carsten Otte
2008-04-04 13:12 ` [PATCH 02/04] kvm-s390: Fix incorrect return value Carsten Otte
2008-04-04 13:12 ` [PATCH 03/04] kvm-s390: Improve pgste accesses Carsten Otte
2008-04-04 13:55 ` Martin Schwidefsky
2008-04-04 14:01 ` Carsten Otte
2008-04-04 21:08 ` Avi Kivity [this message]
2008-04-04 13:12 ` [PATCH 04/04] kvm-s390: rename stfl to kvm_stfl Carsten Otte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47F698D8.7080808@qumranet.com \
--to=avi@qumranet.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=os@de.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox