Re: extboot usage?

[Anthony Liguori <anthony@codemonkey.ws>]

Jun Koi wrote:
> On 4/4/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
>   
>> Jun Koi wrote:
>>
>>     
>>> On 4/4/08, Laurent Vivier <Laurent.Vivier@bull.net> wrote:
>>>
>>>
>>>       
>>>>  Le vendredi 04 avril 2008 à 18:29 +0900, Jun Koi a écrit :
>>>>
>>>>
>>>>
>>>>         
>>>>> On 4/3/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
>>>>>
>>>>>
>>>>>           
>>>>  > > Jun Koi wrote:
>>>>  > >
>>>>  > > > Hi,
>>>>  > > >
>>>>  > > > Could someone please post some concret examples on how to use
>>>>         
>> extboot?
>>     
>>>>  > > > I looked around, but saw nothing.
>>>>  > > >
>>>>  > > >
>>>>  > >
>>>>  > >  Just append boot=on to your -drive parameter.
>>>>  > >
>>>>  >
>>>>  > OK, but the question is that when I need to have "boot=on"? Because
>>>>  > without it (or "boot=off"), -drive still works in some cases, right?
>>>>
>>>>
>>>> You need extboot when you want to boot from a disk which is not managed
>>>>  by IDE controller.
>>>>
>>>>
>>>>         
>>> I see, thanks.
>>>
>>> in extboot.S, I see some dead code, like the macro "callout". Perhaps
>>> it is there for testing. It is better to get rid of it.
>>>
>>>
>>>       
>>  It's debug code and it's not compiled in unless it's used so there's no
>> point in eliminating it.  I personally do not enjoy rewriting 16-bit
>> assembly code :-)
>>     
>
> I understand your feeling :-)
>
> BTW, in the send_command code we have something like this:
>
>     push %ax
>     mov 2(%bx), %ax
>     pop %ax
>
> Just doesnt look right to me.
>   

Yeah, that looks like remnants of debug code to me.  Feel free to submit 
a patch to remove it if you'd like.

Regards,

Anthony Liguori

> Thanks,
> Jun
>
>   
>>  Regards,
>>
>>  Anthony Liguori
>>
>>
>>     
>>> Thanks,
>>> Jun
>>>
>>>
>>>       
>>     


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone