From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 3/4] QEMU/KVM: ignore SIG_IPI signals in userspace Date: Sun, 06 Apr 2008 12:15:07 +0300 Message-ID: <47F8949B.8000409@qumranet.com> References: <20080405182246.761430758@localhost.localdomain> <20080405182320.098125884@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Marcelo Tosatti Return-path: In-Reply-To: <20080405182320.098125884@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > Otherwise a signal can be received in userspace and a vcpu goes back > to the kernel while it should stay still. > > Signed-off-by: Marcelo Tosatti > > Index: kvm-userspace.io/qemu/qemu-kvm.c > =================================================================== > --- kvm-userspace.io.orig/qemu/qemu-kvm.c > +++ kvm-userspace.io/qemu/qemu-kvm.c > @@ -350,7 +350,6 @@ static void *ap_main_loop(void *_env) > vcpu->env = env; > vcpu->env->thread_id = kvm_get_thread_id(); > sigfillset(&signals); > - sigdelset(&signals, SIG_IPI); > sigprocmask(SIG_BLOCK, &signals, NULL); > kvm_create_vcpu(kvm_context, env->cpu_index); > kvm_qemu_init_env(env); > > Does this work with -no-kvm-irqchip? I think we need to fix the kernel to handle random signals. Otherwise even attaching a debugger can change guest behavior (I think). -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone