[PATCH] qemu: avoid returning uninitialized value in apic_mem_readl

[PATCH] qemu: avoid returning uninitialized value in apic_mem_readl

[Carlo Marcelo Arenas Belon]

complement 64173d009c1f4d163c425b14aa650df5b982428a to avoid :

  kvm-65/qemu/hw/apic.c: In function `apic_mem_readl':
  kvm-65/qemu/hw/apic.c:592: warning: 'val' might be used uninitialized in this function

Signed-off-by: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
---
 qemu/hw/apic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
index 4102493..b69ad75 100644
--- a/qemu/hw/apic.c
+++ b/qemu/hw/apic.c
@@ -616,6 +616,7 @@ static uint32_t apic_mem_readl(void *opaque, target_phys_addr_t addr)
         val = apic_get_ppr(s);
         break;
     case 0x0b:
+        val = 0;
         break;
     case 0x0d:
         val = s->log_dest << 24;
-- 
1.5.3.7


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

Re: [PATCH] qemu: avoid returning uninitialized value in apic_mem_readl

[Aurelien Jarno]

Carlo Marcelo Arenas Belon a écrit :
> complement 64173d009c1f4d163c425b14aa650df5b982428a to avoid :
> 
>   kvm-65/qemu/hw/apic.c: In function `apic_mem_readl':
>   kvm-65/qemu/hw/apic.c:592: warning: 'val' might be used uninitialized in this function
> 
> Signed-off-by: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
> ---
>  qemu/hw/apic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/qemu/hw/apic.c b/qemu/hw/apic.c
> index 4102493..b69ad75 100644
> --- a/qemu/hw/apic.c
> +++ b/qemu/hw/apic.c
> @@ -616,6 +616,7 @@ static uint32_t apic_mem_readl(void *opaque, target_phys_addr_t addr)
>          val = apic_get_ppr(s);
>          break;
>      case 0x0b:
> +        val = 0;
>          break;
>      case 0x0d:
>          val = s->log_dest << 24;

The equivalent of commit 64173d009c1f4d163c425b14aa650df5b982428a in
qemu has been done this way. So a merge of qemu SVN should fix this problem.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone