[patch] remove dead code in extboot.S

[patch] remove dead code in extboot.S

[Jun Koi]

[-- Attachment #1: Type: text/plain, Size: 94 bytes --]

Hi,

This patch removes dead code in extboot.S

Signed-off-by: Jun Koi <junkoi2004@gmail.com>

[-- Attachment #2: extboot.diff --]
[-- Type: application/octet-stream, Size: 883 bytes --]

diff --git a/extboot/extboot.S b/extboot/extboot.S
index 9eb9333..723bebd 100644
--- a/extboot/extboot.S
+++ b/extboot/extboot.S
@@ -185,39 +185,6 @@ int19_handler:
 	pop %ax
 .endm
 
-.macro callout value
-	push %bp
-	push %bx
-	mov %sp, %bp
-	alloca $16
-	push %ax
-	push %dx
-
-	mov %ax, 0(%bx)     /* ax */
-	mov 0(%bp), %ax     /* bx */
-	mov %ax, 2(%bx)
-	mov %cx, 4(%bx)     /* cx */
-	mov %dx, 6(%bx)     /* dx */
-	mov %si, 8(%bx)     /* si */
-	mov %ds, 10(%bx)    /* ds */
-	mov %es, 12(%bx)    /* ds */
-	movw \value, 14(%bx) /* value */
-
-	mov %bx, %ax
-	shr $4, %ax
-	mov %ds, %dx
-	add %dx, %ax
-
-	mov $0x407, %dx
-	outw %ax, %dx
-
-	pop %dx
-	pop %ax
-	freea
-	pop %bx
-	pop %bp
-.endm
-
 send_command:
 	push %bp
 	mov %sp, %bp
@@ -239,10 +206,6 @@ send_command:
 	pop %ax
 	pop %bp
 
-	push %ax
-	mov 2(%bx), %ax
-	pop %ax
-
 	ret
 
 add32:  /* lo, hi, lo, hi */

[-- Attachment #3: Type: text/plain, Size: 325 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

[-- Attachment #4: Type: text/plain, Size: 158 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] remove dead code in extboot.S

[Anthony Liguori]

Jun Koi wrote:
> Hi,
>
> This patch removes dead code in extboot.S
>   

Please don't remove the callout macro.

Regards,

Anthony Liguori

> Signed-off-by: Jun Koi <junkoi2004@gmail.com>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

Re: [patch] remove dead code in extboot.S

[Jun Koi]

On 4/7/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Jun Koi wrote:
>
> > Hi,
> >
> > This patch removes dead code in extboot.S
> >
> >
>
>  Please don't remove the callout macro.

I removed it in the patch because even if we keep it, it is unuseable:
it relies on a non-registered IO port (0x407). So to use it, you have
to patch qemu as well.

Thanks,
Jun

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone