From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 0/4] fix SMP migration and loadvm/savevm (V2) Date: Fri, 11 Apr 2008 03:05:22 +0300 Message-ID: <47FEAB42.30304@qumranet.com> References: <20080407203045.583930505@localhost.localdomain> <47FBEAD6.4060908@qumranet.com> <20080409002929.GA12958@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Marcelo Tosatti Return-path: In-Reply-To: <20080409002929.GA12958@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > On Wed, Apr 09, 2008 at 12:59:50AM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> Avi, I prefer not to fold mpstate into kvm_save_registers() as a hidden >>> register because the MPSTATE is only used during migration, whereas >>> save_registers() is not (seems safer) >>> >> But that's the point... what about savevm/loadvm, etc? They deserve to >> work too. >> > > savevm/loadvm will work through cpu_save/cpu_load just as live migration > does, so they are covered. > > Right. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone