From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] kvm-userspace: fix compilation breakage
 when in-kernel pit is not detected
Date: Thu, 10 Apr 2008 23:25:50 -0500
Message-ID: <47FEE84E.30206@codemonkey.ws>
References: <1207830824-1590-1-git-send-email-joerg.roedel@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <1207830824-1590-1-git-send-email-joerg.roedel@amd.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Joerg Roedel wrote:
> The compilation of kvm-userspace part fails if the in-kernel pit is not
> detected in <linux/kvm.h> with the following error message:
>
> pc.o: In function `pc_init1':
> /home/jroedel/src/kvm/kvm-userspace/qemu/hw/pc.c:987: undefined reference to `kvm_pit_init'
> collect2: ld returned 1 exit status
>
> This patch fixes this little issue.
>   

A better solution is to wrap qemu_kvm_put_in_kernel in an #ifdef 
KVM_CAP_PIT so that if it isn't defined, it always returns 0.  gcc will 
then do the right thing.

Regards,

Anthony Liguori

> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  qemu/configure |    1 +
>  qemu/hw/pc.c   |    2 ++
>  2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/qemu/configure b/qemu/configure
> index ca9bce2..bfbd93c 100755
> --- a/qemu/configure
> +++ b/qemu/configure
> @@ -1187,6 +1187,7 @@ configure_kvm() {
>      echo "CONFIG_KVM_KERNEL_INC=$kernel_path/include" >> $config_mak
>      if test $kvm_cap_pit = "yes" ; then
>  	echo "USE_KVM_PIT=1" >> $config_mak
> +	echo "#define USE_KVM_PIT 1" >> $config_h
>      fi
>      disable_cpu_emulation
>    fi
> diff --git a/qemu/hw/pc.c b/qemu/hw/pc.c
> index 859d7db..aa9afea 100644
> --- a/qemu/hw/pc.c
> +++ b/qemu/hw/pc.c
> @@ -983,9 +983,11 @@ static void pc_init1(ram_addr_t ram_size, int vga_ram_size,
>      if (pci_enabled) {
>          ioapic = ioapic_init();
>      }
> +#ifdef USE_KVM_PIT
>      if (kvm_enabled() && qemu_kvm_pit_in_kernel())
>  	pit = kvm_pit_init(0x40, i8259[0]);
>      else
> +#endif
>  	pit = pit_init(0x40, i8259[0]);
>      pcspk_init(pit);
>      if (pci_enabled) {
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone