Re: [PATCH] kvm-userspace: fix compilation breakage when in-kernel pit is not detected

[Avi Kivity <avi@qumranet.com>]

Anthony Liguori wrote:
> Joerg Roedel wrote:
>> The compilation of kvm-userspace part fails if the in-kernel pit is not
>> detected in <linux/kvm.h> with the following error message:
>>
>> pc.o: In function `pc_init1':
>> /home/jroedel/src/kvm/kvm-userspace/qemu/hw/pc.c:987: undefined 
>> reference to `kvm_pit_init'
>> collect2: ld returned 1 exit status
>>
>> This patch fixes this little issue.
>>   
>
> A better solution is to wrap qemu_kvm_put_in_kernel in an #ifdef 
> KVM_CAP_PIT so that if it isn't defined, it always returns 0.  gcc 
> will then do the right thing.
>

I would like to move qemu from depending on linux/kvm.h directly.  
However, there is a lot of work needed to get that (including some 
pointless stuff like defining libkvm structures to take the place of 
kvm.h structures) so perhaps it is not a realistic goal.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone