From: Carsten Otte <cotte@de.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel@lists.sourceforge.net, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 1/2] KVM: hlt emulation should take in-kernel APIC/PIT timers into account
Date: Sat, 12 Apr 2008 00:30:57 +0200 [thread overview]
Message-ID: <47FFE6A1.1010301@de.ibm.com> (raw)
In-Reply-To: <47FF55B9.2010607@qumranet.com>
Avi Kivity wrote:
>> @@ -765,6 +766,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcp
>>
>
>
> This breaks ia64 (and shouldn't s390 use this too?)
>> * We will block until either an interrupt or a signal wakes us up
>> */
>> while (!kvm_cpu_has_interrupt(vcpu)
>> + && !kvm_cpu_has_pending_timer(vcpu)
>>
>
> I guess the fix is to stub this out for the other archs.
We don't use that, we have our own implementation of vcpu_block.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-11 22:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 20:12 [patch 0/2] fix in-kernel timer / IRQ injection races Marcelo Tosatti
2008-04-10 20:12 ` [patch 1/2] KVM: hlt emulation should take in-kernel APIC/PIT timers into account Marcelo Tosatti
2008-04-11 12:12 ` Avi Kivity
2008-04-11 17:53 ` Marcelo Tosatti
2008-04-13 9:28 ` Avi Kivity
2008-05-09 7:49 ` Yang, Sheng
2008-05-09 14:53 ` Marcelo Tosatti
2008-05-10 2:12 ` Yang, Sheng
2008-05-12 16:40 ` Marcelo Tosatti
2008-05-14 3:03 ` Yang, Sheng
2008-04-11 22:30 ` Carsten Otte [this message]
2008-04-13 9:47 ` Avi Kivity
2008-04-14 9:18 ` Carsten Otte
2008-04-10 20:12 ` [patch 2/2] KVM: fix kvm_vcpu_kick vs __vcpu_run race Marcelo Tosatti
2008-04-11 12:18 ` Avi Kivity
2008-04-11 18:01 ` Marcelo Tosatti
2008-04-13 10:08 ` Avi Kivity
2008-04-13 16:07 ` Avi Kivity
2008-04-13 16:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47FFE6A1.1010301@de.ibm.com \
--to=cotte@de.ibm.com \
--cc=avi@qumranet.com \
--cc=carsteno@de.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox