Re: [patch 1/2] KVM: hlt emulation should take in-kernel APIC/PIT timers into account

Avi Kivity
2008-04-13T09:47:44Z

Carsten Otte wrote:
> Avi Kivity wrote:
>>> @@ -765,6 +766,7 @@ void kvm_vcpu_block(struct kvm_vcpu *vcp
>>>
>>
>>
>> This breaks ia64 (and shouldn't s390 use this too?)
>>> * We will block until either an interrupt or a signal wakes us up
>>> */
>>> while (!kvm_cpu_has_interrupt(vcpu)
>>> + && !kvm_cpu_has_pending_timer(vcpu)
>>>
>>
>> I guess the fix is to stub this out for the other archs.
>
> We don't use that, we have our own implementation of vcpu_block.

Why?

--
error compiling committee.c: too many arguments to function