From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 1/2] KVM: Expose get_eoi_gsi() for IRQ
 acking by	PCI passthrough devices
Date: Sun, 13 Apr 2008 11:22:25 +0300
Message-ID: <4801C2C1.5060603@qumranet.com>
References: <1207817334-31775-1-git-send-email-amit.shah@qumranet.com>
	<1207817334-31775-2-git-send-email-amit.shah@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: chrisw@redhat.com, kvm-devel@lists.sourceforge.net,
	allen.m.kay@intel.com, virtualization@lists.linux-foundation.org,
	gcosta@redhat.com, BENAMI@il.ibm.com
To: Amit Shah <amit.shah@qumranet.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <1207817334-31775-2-git-send-email-amit.shah@qumranet.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Amit Shah wrote:
>  
> -static int get_eoi_gsi(struct kvm_ioapic *ioapic, int vector)
> +int get_eoi_gsi(struct kvm_ioapic *ioapic, int vector)
>   

Such a generic name should be prefixed by kvm_ if you expose it.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone