From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 1/2] KVM: hlt emulation should take in-kernel APIC/PIT timers into account Date: Sun, 13 Apr 2008 12:28:22 +0300 Message-ID: <4801D236.6000604@qumranet.com> References: <20080410201254.316224847@localhost.localdomain> <20080410201402.382704482@localhost.localdomain> <47FF55B9.2010607@qumranet.com> <20080411175326.GA3800@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Carsten Otte To: Marcelo Tosatti Return-path: In-Reply-To: <20080411175326.GA3800@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > On Fri, Apr 11, 2008 at 03:12:41PM +0300, Avi Kivity wrote: > > >> This breaks ia64 (and shouldn't s390 use this too?) >> >>> * We will block until either an interrupt or a signal wakes us up >>> */ >>> while (!kvm_cpu_has_interrupt(vcpu) >>> + && !kvm_cpu_has_pending_timer(vcpu) >>> >>> >> I guess the fix is to stub this out for the other archs. >> > > Agreed. How's this. > > Better :); applied. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone