From: Avi Kivity <avi@qumranet.com>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net
Subject: Re: [PATCH] [v2] Move kvm_get_pit to libkvm.c common code
Date: Sun, 13 Apr 2008 17:24:03 +0300 [thread overview]
Message-ID: <48021783.4070407@qumranet.com> (raw)
In-Reply-To: <8ddf560729aac228cd84.1207692907@thinkpadL>
Jerone Young wrote:
> - I am resending this patch removing ia64. It apprently fell through the cracks.
>
> Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT.
>
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
> --- a/libkvm/libkvm.h
> +++ b/libkvm/libkvm.h
> @@ -549,6 +549,7 @@ int kvm_pit_in_kernel(kvm_context_t kvm)
>
> #ifdef KVM_CAP_PIT
>
> +#if defined(__i386__) || defined(__x86_64__)
> /*!
> * \brief Get in kernel PIT of the virtual domain
> *
> @@ -569,6 +570,7 @@ int kvm_get_pit(kvm_context_t kvm, struc
> * \param s PIT state of the virtual domain
> */
> int kvm_set_pit(kvm_context_t kvm, struct kvm_pit_state *s);
> +#endif
>
> #endif
Patch is okay, but doesn't match the description at all. Is this what
you intended to send?
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-13 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 22:15 [PATCH] [v2] Move kvm_get_pit to libkvm.c common code Jerone Young
2008-04-13 14:24 ` Avi Kivity [this message]
2008-04-14 1:08 ` Jerone Young
2008-04-15 7:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48021783.4070407@qumranet.com \
--to=avi@qumranet.com \
--cc=jyoung5@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ppc-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox