[PATCH] [v2] Move kvm_get_pit to libkvm.c common code

[PATCH] [v2] Move kvm_get_pit to libkvm.c common code

[Jerone Young]

# HG changeset patch
# User Jerone Young <jyoung5@us.ibm.com>
# Date 1207692873 18000
# Branch merge
# Node ID 8ddf560729aac228cd84068e1227e601e68a6840
# Parent  94cbc19df0f0fcab150599b10d859f1a3bc1b7cb
[v2] Move kvm_get_pit to libkvm.c common code

	- I am resending this patch removing ia64. It apprently fell through the cracks.

Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT.

        Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
	Signed-off-by: Jerone Young <jyoung5@us.ibm.com>

diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
--- a/libkvm/libkvm.h
+++ b/libkvm/libkvm.h
@@ -549,6 +549,7 @@ int kvm_pit_in_kernel(kvm_context_t kvm)
 
 #ifdef KVM_CAP_PIT
 
+#if defined(__i386__) || defined(__x86_64__)
 /*!
  * \brief Get in kernel PIT of the virtual domain
  *
@@ -569,6 +570,7 @@ int kvm_get_pit(kvm_context_t kvm, struc
  * \param s PIT state of the virtual domain
  */
 int kvm_set_pit(kvm_context_t kvm, struct kvm_pit_state *s);
+#endif
 
 #endif
 

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Register now and save $200. Hurry, offer ends at 11:59 p.m., 
Monday, April 7! Use priority code J8TLD2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

Re: [PATCH] [v2] Move kvm_get_pit to libkvm.c common code

[Avi Kivity]

Jerone Young wrote:
> 	- I am resending this patch removing ia64. It apprently fell through the cracks.
>
> Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT.
>
>         Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> 	Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
>
> diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
> --- a/libkvm/libkvm.h
> +++ b/libkvm/libkvm.h
> @@ -549,6 +549,7 @@ int kvm_pit_in_kernel(kvm_context_t kvm)
>  
>  #ifdef KVM_CAP_PIT
>  
> +#if defined(__i386__) || defined(__x86_64__)
>  /*!
>   * \brief Get in kernel PIT of the virtual domain
>   *
> @@ -569,6 +570,7 @@ int kvm_get_pit(kvm_context_t kvm, struc
>   * \param s PIT state of the virtual domain
>   */
>  int kvm_set_pit(kvm_context_t kvm, struct kvm_pit_state *s);
> +#endif
>  
>  #endif

Patch is okay, but doesn't match the description at all.  Is this what 
you intended to send?

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

Re: [PATCH] [v2] Move kvm_get_pit to libkvm.c common code

[Jerone Young]

I just took the old description that was there before. A much better one
would be:

Remove declarations of kvm_*_pit() on architectures who do not support
not have a PIT.

That is what I was really intending. It removes a lot of compile
warnings, when compiling anything with libkvm.h on platforms that do not
have a pit. It's mainly because of the structures that are used as
arguments to these function declrations.


On Sun, 2008-04-13 at 17:24 +0300, Avi Kivity wrote:
> Jerone Young wrote:
> > 	- I am resending this patch removing ia64. It apprently fell through the cracks.
> >
> > Don't compile kvm_*_pit() on architectures whose currently supported platforms do not contain a PIT.
> >
> >         Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> > 	Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> >
> > diff --git a/libkvm/libkvm.h b/libkvm/libkvm.h
> > --- a/libkvm/libkvm.h
> > +++ b/libkvm/libkvm.h
> > @@ -549,6 +549,7 @@ int kvm_pit_in_kernel(kvm_context_t kvm)
> >  
> >  #ifdef KVM_CAP_PIT
> >  
> > +#if defined(__i386__) || defined(__x86_64__)
> >  /*!
> >   * \brief Get in kernel PIT of the virtual domain
> >   *
> > @@ -569,6 +570,7 @@ int kvm_get_pit(kvm_context_t kvm, struc
> >   * \param s PIT state of the virtual domain
> >   */
> >  int kvm_set_pit(kvm_context_t kvm, struct kvm_pit_state *s);
> > +#endif
> >  
> >  #endif
> 
> Patch is okay, but doesn't match the description at all.  Is this what 
> you intended to send?
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

Re: [PATCH] [v2] Move kvm_get_pit to libkvm.c common code

[Avi Kivity]

Jerone Young wrote:
> I just took the old description that was there before. A much better one
> would be:
>
> Remove declarations of kvm_*_pit() on architectures who do not support
> not have a PIT.
>
> That is what I was really intending. It removes a lot of compile
> warnings, when compiling anything with libkvm.h on platforms that do not
> have a pit. It's mainly because of the structures that are used as
> arguments to these function declrations.
>   

Thanks, applied.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone