From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anders <mail@flac.kalibalik.dk>
Subject: Re: [patch 2/2] QEMU: decrease console "refresh rate"
	with -nographic
Date: Sun, 13 Apr 2008 18:30:34 +0200
Message-ID: <4802352A.4010105@flac.kalibalik.dk>
References: <20080411183852.150819622@localhost.localdomain>
	<20080411184851.559593822@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <20080411184851.559593822@localhost.localdomain>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Marcelo Tosatti wrote:

> With SIGIO enabled on stdio, there's no need to wakeup the thread
> performing IO every 30ms.
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> 
> Index: kvm-userspace.io/qemu/vl.c
> ===================================================================
> --- kvm-userspace.io.orig/qemu/vl.c
> +++ kvm-userspace.io/qemu/vl.c
> @@ -5640,6 +5640,7 @@ static void dumb_display_init(DisplaySta
>      ds->dpy_update = dumb_update;
>      ds->dpy_resize = dumb_resize;
>      ds->dpy_refresh = dumb_refresh;
> +    ds->gui_timer_interval = 1000;
>  }
>  
>  /***********************************************************/
> 

Why even the 1000ms timer? I was proposing to just set ds->dpy_refresh 
to NULL for the dumb_display, but hit the qemu-devel dead-end.

http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00374.html

Do you see a problem with that approach? If yes, then that problem is 
probably currently present in the unconnected VNC case, as that one now 
disables the periodic timer completely.

Cheers,
Anders.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone