From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH] wrong pa calculation fix (extboot) Date: Mon, 14 Apr 2008 10:13:15 -0500 Message-ID: <4803748B.4090400@us.ibm.com> References: <9cde8bff0804140338o915fe62y4032947cd87d46ac@mail.gmail.com> <480366FA.9050608@us.ibm.com> <9cde8bff0804140747x5e9b072eva2c269a897c8dede@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Nguyen Anh Quynh Return-path: In-Reply-To: <9cde8bff0804140747x5e9b072eva2c269a897c8dede@mail.gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Nguyen Anh Quynh wrote: > On 4/14/08, Anthony Liguori wrote: > >> In practice, this check isn't actually necessary since a guest always has >> at least 1MB of memory. >> > > Agreed. But it needs to be fixed, anyway. Or we can remove it. > I should mention, the reason for removing the check, is that what we really want to do is remove all references to phys_ram_base() and replace them with cpu_physical_memory_{read,write}(). That will enforce memory checking. Regards, Anthony Liguori > Thanks, > Q > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone