Re: [PATCH] [kvm-userspace] Make "make sync" in kernel dir work for multiple archs

Jerone Young
2008-04-15T16:20:58Z

On Tue, 2008-04-15 at 09:08 -0500, Hollis Blanchard wrote:
> On Monday 14 April 2008 21:46:43 Jerone Young wrote:
> > 1 file changed, 13 insertions(+), 5 deletions(-)
> > kernel/Makefile | 18 +++++++++++++-----
> >
> >
> > This patch add the ability for make sync in the kernel directory to work
> > for mulitiple architectures and not just x86.
> >
> > Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> >
> > diff --git a/kernel/Makefile b/kernel/Makefile
> > --- a/kernel/Makefile
> > +++ b/kernel/Makefile
> > @@ -1,5 +1,10 @@ include ../config.mak
> > include ../config.mak
> >
> > +ASM_DIR=$(ARCH)
> > +ifneq '$(filter $(ASM_DIR), x86_64 i386 ia64)' ''
> > + ASM_DIR=x86
> > +endif
>
> Minor complaint: "ASM_DIR" really isn't. You use it as arch/$(ASM_DIR) and
> also as include/asm-$(ASM_DIR). I think what you really meant is "ARCH_DIR"
> (or similar).

I can change it. Not that big of a deal. Oh left the ia64 on there by
accident.

>
> > +ifneq '$(filter $(ASM_DIR), x86_64 i386 ia64)' ''
> > $(call unifdef, include/linux/kvm.h)
> > $(call unifdef, include/linux/kvm_para.h)
> > $(call unifdef, include/asm-x86/kvm.h)
> > @@ -54,6 +60,8 @@ sync:
> > $(call hack, svm.c)
> > $(call hack, x86.c)
> > $(call hack, irq.h)
> > +endif
> > +
>
> Why are you keeping IA64 touching asm-x86?
Accident. Cut and past error from the first mistake.

>
> What happened to my suggestion of creating a per-arch HACK_FILES and
> UNIFDEF_FILES variables, and looping over those?

These macros are only for x86. We don't want them or need them. So I
just left them be as not to accidentally miss or break anything.