Re: [patch 2/2] QEMU: decrease console "refresh rate" with -nographic

Anders
2008-04-13T16:30:34Z

Marcelo Tosatti wrote:

> With SIGIO enabled on stdio, there's no need to wakeup the thread
> performing IO every 30ms.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Index: kvm-userspace.io/qemu/vl.c
> ===================================================================
> --- kvm-userspace.io.orig/qemu/vl.c
> +++ kvm-userspace.io/qemu/vl.c
> @@ -5640,6 +5640,7 @@ static void dumb_display_init(DisplaySta
> ds->dpy_update = dumb_update;
> ds->dpy_resize = dumb_resize;
> ds->dpy_refresh = dumb_refresh;
> + ds->gui_timer_interval = 1000;
> }
>
> /***********************************************************/
>

Why even the 1000ms timer? I was proposing to just set ds->dpy_refresh
to NULL for the dumb_display, but hit the qemu-devel dead-end.

http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00374.html

Do you see a problem with that approach? If yes, then that problem is
probably currently present in the unconnected VNC case, as that one now
disables the periodic timer completely.

Cheers,
Anders.