From: "H. Peter Anvin" <hpa@zytor.com>
To: Nguyen Anh Quynh <aquynh@gmail.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: Extboot Option ROM rewritten in C - v3
Date: Thu, 17 Apr 2008 01:58:59 -0400 [thread overview]
Message-ID: <4806E723.9010508@zytor.com> (raw)
In-Reply-To: <9cde8bff0804161830j74ad21f9r7fb1bc5b1e7ab28e@mail.gmail.com>
Nguyen Anh Quynh wrote:
> This patch replaces the current assembly code of Extboot option rom
> with new C code. Patch is against kvm-66.
>
> This version returns an error code in case int 13 handler cannot
> handle a requested function.
>
> Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>
>
+ /* -fomit-frame-pointer might clobber %ebp */
+ pushl %ebp
+ call setup
+ popl %ebp
No, it might not. %ebx, %ebp, %esi, and %edi are guaranteed preserved;
%eax, %ecx and %edx are clobbered.
It's also prudent to call cld before jumping to C code.
-hpa
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-17 5:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 1:30 Extboot Option ROM rewritten in C - v3 Nguyen Anh Quynh
2008-04-17 5:58 ` H. Peter Anvin [this message]
2008-04-18 10:57 ` Nguyen Anh Quynh
2008-04-17 6:00 ` H. Peter Anvin
2008-04-18 11:00 ` Nguyen Anh Quynh
2008-04-18 12:21 ` H. Peter Anvin
2008-04-18 13:19 ` Anthony Liguori
2008-04-18 12:24 ` H. Peter Anvin
2008-04-18 13:19 ` Anthony Liguori
2008-04-18 13:31 ` H. Peter Anvin
2008-04-18 13:56 ` Nguyen Anh Quynh
2008-04-18 14:51 ` Anthony Liguori
2008-04-18 14:50 ` H. Peter Anvin
2008-04-18 15:02 ` Nguyen Anh Quynh
2008-04-18 15:19 ` Anthony Liguori
2008-04-17 7:36 ` Carlo Marcelo Arenas Belon
2008-04-18 11:01 ` Nguyen Anh Quynh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4806E723.9010508@zytor.com \
--to=hpa@zytor.com \
--cc=aquynh@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox