* [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion
@ 2008-04-15 18:51 Jerone Young
2008-04-15 18:51 ` [PATCH 1 of 2] Add kvm_load_registers into qemu_arch_init for PowerPC Jerone Young
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-15 18:51 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
This patch apparently fell through the cracks or I didn't send the rised version to the list. These patches fix cpu initilization for PowerPC. Without them guest cannot be launched.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
2 files changed, 6 insertions(+), 3 deletions(-)
qemu/hw/ppc440_bamboo.c | 3 ---
qemu/qemu-kvm-powerpc.c | 6 ++++++
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1 of 2] Add kvm_load_registers into qemu_arch_init for PowerPC
2008-04-15 18:51 [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Jerone Young
@ 2008-04-15 18:51 ` Jerone Young
2008-04-15 18:51 ` [PATCH 2 of 2] Remove kvm_load_registers from ppc440_bamboo board model Jerone Young
2008-04-17 9:41 ` [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Avi Kivity
2 siblings, 0 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-15 18:51 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
1 file changed, 6 insertions(+)
qemu/qemu-kvm-powerpc.c | 6 ++++++
This patch adds a call to load_kvm_registers after creation of vcpu. This is required for ppc since we are required to set certain registers before boot.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
diff --git a/qemu/qemu-kvm-powerpc.c b/qemu/qemu-kvm-powerpc.c
--- a/qemu/qemu-kvm-powerpc.c
+++ b/qemu/qemu-kvm-powerpc.c
@@ -121,6 +121,12 @@ void kvm_arch_save_regs(CPUState *env)
int kvm_arch_qemu_init_env(CPUState *cenv)
{
+ if (cenv->cpu_index == 0) {
+ /* load any registers set in env into
+ kvm for the first guest vcpu */
+ kvm_load_registers(cenv);
+ }
+
return 0;
}
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2 of 2] Remove kvm_load_registers from ppc440_bamboo board model
2008-04-15 18:51 [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Jerone Young
2008-04-15 18:51 ` [PATCH 1 of 2] Add kvm_load_registers into qemu_arch_init for PowerPC Jerone Young
@ 2008-04-15 18:51 ` Jerone Young
2008-04-17 9:41 ` [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Avi Kivity
2 siblings, 0 replies; 4+ messages in thread
From: Jerone Young @ 2008-04-15 18:51 UTC (permalink / raw)
To: kvm-devel; +Cc: kvm-ppc-devel
1 file changed, 3 deletions(-)
qemu/hw/ppc440_bamboo.c | 3 ---
This patch removes the call to kvm_load_registers while in board platform setup code. This must now be done later in vcpu initialization.
Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
diff --git a/qemu/hw/ppc440_bamboo.c b/qemu/hw/ppc440_bamboo.c
--- a/qemu/hw/ppc440_bamboo.c
+++ b/qemu/hw/ppc440_bamboo.c
@@ -174,9 +174,6 @@ void bamboo_init(ram_addr_t ram_size, in
env->gpr[3] = dt_base;
#endif
env->nip = ep;
-
- printf("%s: loading kvm registers\n", __func__);
- kvm_load_registers(env);
}
for (i = 0; i < nb_nics; i++) {
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion
2008-04-15 18:51 [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Jerone Young
2008-04-15 18:51 ` [PATCH 1 of 2] Add kvm_load_registers into qemu_arch_init for PowerPC Jerone Young
2008-04-15 18:51 ` [PATCH 2 of 2] Remove kvm_load_registers from ppc440_bamboo board model Jerone Young
@ 2008-04-17 9:41 ` Avi Kivity
2 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2008-04-17 9:41 UTC (permalink / raw)
To: Jerone Young; +Cc: kvm-devel, kvm-ppc-devel
Jerone Young wrote:
> This patch apparently fell through the cracks or I didn't send the rised version to the list. These patches fix cpu initilization for PowerPC. Without them guest cannot be launched.
>
>
Applied both, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-17 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-15 18:51 [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Jerone Young
2008-04-15 18:51 ` [PATCH 1 of 2] Add kvm_load_registers into qemu_arch_init for PowerPC Jerone Young
2008-04-15 18:51 ` [PATCH 2 of 2] Remove kvm_load_registers from ppc440_bamboo board model Jerone Young
2008-04-17 9:41 ` [PATCH 0 of 2] [RESEND] Fix PowerPC cpu initiliaztion Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox