From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Ehrhardt Subject: Re: [PATCH 4 of 4] [KVM POWERPC] PowerPC 440 KVM implementation Date: Thu, 17 Apr 2008 16:00:37 +0200 Message-ID: <48075805.2030602@linux.vnet.ibm.com> References: <442f314cd08ea6addd39.1208406489@localhost.localdomain> <4807311D.3020402@qumranet.com> <4807324F.70202@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040208000503080501090909" Cc: kvm-ppc-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org, Hollis Blanchard , kvm-devel@lists.sourceforge.net To: Avi Kivity Return-path: In-Reply-To: <4807324F.70202@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------040208000503080501090909 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Avi Kivity wrote: >> Hollis Blanchard wrote: >>> +config KVM >>> + tristate "Kernel-based Virtual Machine (KVM) support" >>> + depends on EXPERIMENTAL >>> + select PREEMPT_NOTIFIERS >>> + select ANON_INODES >>> + ---help--- >>> + Support hosting virtualized guest machines. You will also >>> + need to select one or more of the processor modules below. >>> + >>> + This module provides access to the hardware capabilities through >>> + a character device node named /dev/kvm. >>> + >>> + To compile this as a module, choose M here: the module >>> + will be called kvm. >>> + >>> + If unsure, say N. >> >> In my ignorance, I set KVM=3Dm on a non-44x build, which then failed.=20 >> This needs either to depend on 44x, or to be fixed to compile. >=20 > Setting 44x, I get >> AS [M] arch/powerpc/kvm/booke_interrupts.o >> arch/powerpc/kvm/booke_interrupts.S: Assembler messages: >> arch/powerpc/kvm/booke_interrupts.S:351: Error: unsupported relocation= =20 >> against VCPU_HOST_TLB >> arch/powerpc/kvm/booke_interrupts.S:352: Error: unsupported relocation= =20 >> against VCPU_SHADOW_TLB Afaik we just don't support building kvm as module atm. So a simple and f= ast solution would be to change the Kconfig options from tristate to bool= . Additionally we still have some cross references between the code build o= n the two used symbols (KVM&KVM_BOOKE_HOST) which means that we need to e= nsure that if KVM if configured for powerpc we also select exactly one ho= st implementation. To do so I changed the second option to a choice field= which eventually has always selected one suboption. To ensure that the only existent suboption we have atm can be selected we= need the smallest commonality as dependency at the KVM config option whi= ch atm put "depends 44x" there. We can change that once we support modules and/or separate selections. A patch for that is attached, but I would like to wait for Hollis comment= s on that before you apply that. > So further Kconfig restrictions are needed, or perhaps a patch. .config= =20 > attached. >=20 >=20 [...] --=20 Gr=FCsse / regards,=20 Christian Ehrhardt IBM Linux Technology Center, Open Virtualization --------------040208000503080501090909 Content-Type: text/x-patch; name="fix_kvmppc_nomodule_build.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix_kvmppc_nomodule_build.diff" --- arch/powerpc/kvm/Kconfig.save 2008-04-17 15:21:54.000000000 +0200 +++ arch/powerpc/kvm/Kconfig 2008-04-17 15:58:52.000000000 +0200 @@ -15,8 +15,8 @@ if VIRTUALIZATION config KVM - tristate "Kernel-based Virtual Machine (KVM) support" - depends on EXPERIMENTAL + bool "Kernel-based Virtual Machine (KVM) support" + depends on EXPERIMENTAL && 44x select PREEMPT_NOTIFIERS select ANON_INODES ---help--- @@ -31,13 +31,22 @@ If unsure, say N. +choice + prompt "KVM host PowerPC processor support" + depends on KVM && 44x + default KVM_BOOKE_HOST + help + This option sets the Kind of PowerPC processor to virtualize. + config KVM_BOOKE_HOST - tristate "KVM host support for Book E PowerPC processors" + bool "Book E" depends on KVM && 44x ---help--- Provides host support for KVM on Book E PowerPC processors. Currently this works on 440 processors only. +endchoice + source drivers/virtio/Kconfig endif # VIRTUALIZATION --------------040208000503080501090909 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone --------------040208000503080501090909 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------040208000503080501090909--