From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: Re: [kvm-devel] [PATCH 1/3] Refactor AIO interface
	to allow other AIO implementations
Date: Fri, 18 Apr 2008 10:23:31 -0500
Message-ID: <4808BCF3.3060200@us.ibm.com>
References: <1208460412-27567-1-git-send-email-aliguori@us.ibm.com>
	<20080417193807.GB11916@redhat.com> <4807A7EC.6040408@us.ibm.com>
	<20080417200024.GC11916@redhat.com>
	<20080418124319.GC25089@shareable.org>
Reply-To: qemu-devel@nongnu.org
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@us.ibm.com>, kvm-devel@lists.sourceforge.net,
	Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <20080418124319.GC25089@shareable.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
List-Id: kvm.vger.kernel.org

Jamie Lokier wrote:
>> I've basically got a choice of making libvirt always ad '-aio linux'
>> or never add it at all. My inclination is to the latter since it is
>> compatible with existing QEMU which has no -aio option. Presumably
>> '-aio linux' is intended to provide some performance benefit so it'd
>> be nice to use it. If we can't express some criteria under which it
>> should be turned on, I can't enable it; where as if you can express
>> some criteria, then QEMU should apply them automatically.
>>     
>
> I'm of the view that '-aio auto' would be a really good option - and
> when it's proven itself, it should be the default.  It could work on
> all QEMU hosts: it would pick synchronous IO when there is nothing else.
>   

Right now, not specifying the -aio option is equivalent to your proposed 
-aio auto.

I guess I should include an info aio to let the user know what type of 
aio they are using.  We can add selection criteria later but 
semantically, not specifying an explicit -aio option allows QEMU to 
choose whichever one it thinks is best.

Regards,

Anthony Liguori