From: Avi Kivity <avi@qumranet.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: kvm-devel@lists.sourceforge.net
Subject: Re: [PATCH] SVM: remove selective CR0 comment
Date: Fri, 18 Apr 2008 19:08:54 +0300 [thread overview]
Message-ID: <4808C796.208@qumranet.com> (raw)
In-Reply-To: <1208358065-28800-1-git-send-email-joerg.roedel@amd.com>
Joerg Roedel wrote:
> There is not selective cr0 intercept bug. The code in the comment sets the
> CR0.PG bit. But KVM sets the CR4.PG bit for SVM always to implement the paged
> real mode. So the 'mov %eax,%cr0' instruction does not change the CR0.PG bit.
> Selective CR0 intercepts only occur when a bit is actually changed. So its the
> right behavior that there is no intercept on this instruction.
>
>
Applied, thanks.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
prev parent reply other threads:[~2008-04-18 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-16 15:01 [PATCH] SVM: remove selective CR0 comment Joerg Roedel
2008-04-18 16:08 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4808C796.208@qumranet.com \
--to=avi@qumranet.com \
--cc=joerg.roedel@amd.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox