From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] SVM: remove selective CR0 comment Date: Fri, 18 Apr 2008 19:08:54 +0300 Message-ID: <4808C796.208@qumranet.com> References: <1208358065-28800-1-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Joerg Roedel Return-path: In-Reply-To: <1208358065-28800-1-git-send-email-joerg.roedel@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Joerg Roedel wrote: > There is not selective cr0 intercept bug. The code in the comment sets the > CR0.PG bit. But KVM sets the CR4.PG bit for SVM always to implement the paged > real mode. So the 'mov %eax,%cr0' instruction does not change the CR0.PG bit. > Selective CR0 intercepts only occur when a bit is actually changed. So its the > right behavior that there is no intercept on this instruction. > > Applied, thanks. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone