From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] gfxboot VMX workaround v2 Date: Sun, 20 Apr 2008 10:52:09 +0300 Message-ID: <480AF629.9020908@qumranet.com> References: <47FA1DD5.3050500@suse.de> <47FA4632.9040403@codemonkey.ws> <20080415110755.183ba530@frecb000711.frec.bull.fr> <4804A863.4040300@qumranet.com> <20080418141816.29e745f0@frecb000711.frec.bull.fr> <4808A0BB.20500@codemonkey.ws> <20080418160528.457c274f@frecb000711.frec.bull.fr> <4808BD5B.3040103@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Guillaume Thouvenin To: Anthony Liguori Return-path: In-Reply-To: <4808BD5B.3040103@codemonkey.ws> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > > I'd prefer you not do an emulate_instruction loop at all. Just > emulate one instruction on vmentry failure and let VT tell you what > instructions you need to emulate. > > It's only four instructions so I don't think the performance is going > to matter. Take a look at the patch I posted previously. Once we remove the other VT realmode hacks, we may need more instructions emulated. Consider for example changing to real mode without reloading fs and gs; this will cause all real mode code to be emulated. However, there's no need to do everything at once; the loop can certainly be added later when we have a proven need for it. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone