Re: [patch 0/2] pci_register_device can fail

[Avi Kivity <avi@qumranet.com>]

Chris Wright wrote:
> The pci hotadd patches make it easy to trigger segfaults when adding more
> devices than a single PCI bus can handle.  The following 2 patches fix the
> pci nic devices and virtio-blk device.  Now the following the following:
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 nic model=virtio
>   Segmentation fault
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 storage file=/mnt/disk1,if=virtio
>   Segmentation fault
>
> become:
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 nic model=virtio
>   qemu: Unable to initialze NIC: virtio
>   failed to add model=virtio
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 storage file=/mnt/disk1,if=virtio
>   failed to add file=/mnt/disk1,if=virtio
>   

Applied all three, thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone