From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [patch 0/2] pci_register_device can fail
Date: Tue, 22 Apr 2008 14:21:20 +0300
Message-ID: <480DCA30.2020202@qumranet.com>
References: <20080421230247.814678086@sous-sol.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net,
	Marcelo Tosatti <mtosatti@redhat.com>
To: Chris Wright <chrisw@sous-sol.org>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <20080421230247.814678086@sous-sol.org>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Chris Wright wrote:
> The pci hotadd patches make it easy to trigger segfaults when adding more
> devices than a single PCI bus can handle.  The following 2 patches fix the
> pci nic devices and virtio-blk device.  Now the following the following:
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 nic model=virtio
>   Segmentation fault
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 storage file=/mnt/disk1,if=virtio
>   Segmentation fault
>
> become:
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 nic model=virtio
>   qemu: Unable to initialze NIC: virtio
>   failed to add model=virtio
>
>   OK bus 0, slot 31, function 0 (devfn 248)
>   (qemu) pci_add 0 storage file=/mnt/disk1,if=virtio
>   failed to add file=/mnt/disk1,if=virtio
>   

Applied all three, thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone