From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH] virtio: change config to guest endian. Date: Tue, 22 Apr 2008 14:22:48 +0300 Message-ID: <480DCA88.4010407@qumranet.com> References: <200804221357.34571.rusty@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Christian Borntraeger , Hollis Blanchard , virtualization@lists.linux-foundation.org To: Rusty Russell Return-path: In-Reply-To: <200804221357.34571.rusty@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Rusty Russell wrote: > [Christian, Hollis, how much is this ABI breakage going to hurt you?] > > A recent proposed feature addition to the virtio block driver revealed > some flaws in the API, in particular how easy it is to break big > endian machines. > > The virtio config space was originally chosen to be little-endian, > because we thought the config might be part of the PCI config space > for virtio_pci. It's actually a separate mmio region, so that > argument holds little water; as only x86 is currently using the virtio > mechanism, we can change this (but must do so now, before the > impending s390 and ppc merges). > > This will probably annoy Hollis which has guests that can go both ways. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone