Re: [PATCH 1/2]kvmtrace: add event mask support (kernel part)

[Avi Kivity <avi@qumranet.com>]

Liu, Eric E wrote:
> >From a1b062cfd4d1a91c447b680ac9a2250fe55119ec Mon Sep 17 00:00:00 2001
> From: Feng (Eric) Liu <eric.e.liu@intel.com>
> Date: Wed, 16 Apr 2008 05:29:37 -0400
> Subject: [PATCH] KVM: trace: Add event mask support.
>
> Allow user space application to specify one or more
> filter masks to limit the events being captured via it.
>
>   

Sorry about the late review.

> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -18,6 +18,8 @@
>  struct kvm_user_trace_setup {
>  	__u32 buf_size; /* sub_buffer size of each per-cpu */
>  	__u32 buf_nr; /* the number of sub_buffers of each per-cpu */
> +	__u16 cat_mask; /* the tracing categories are enabled */
> +	__u64 act_bitmap[16]; /* the actions are enabled for each
> category */
>  };
>   

The structures will be laid out differently on 32-bit and 64-bit.  This 
is important since we'd like 32-bit userspace to work correctly with a 
64-bit kernel.  The usual solution is to insert a "__u16 pad1[3];" 
between the two fields.

Otherwise, the patch seems fine.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone