From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/6] kvm: qemu: Enable EPT support for real mode Date: Thu, 24 Apr 2008 10:37:53 +0300 Message-ID: <481038D1.4030809@qumranet.com> References: <200804181730.16318.sheng.yang@intel.com> <200804241459.09523.sheng.yang@intel.com> <48103392.4010808@qumranet.com> <200804241529.57878.sheng.yang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: "Yang, Sheng" Return-path: In-Reply-To: <200804241529.57878.sheng.yang@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Yang, Sheng wrote: >> Why not use ept_identity_pagetable != NULL to encode >> ept_identity_pagetable_done? >> > > ept_identity_pagetable_done was used to indicate if the pagetable was setted > up, and ept_identity_pagetable was used to indicate if the page used for > pagetable was allocated... I don't want to run alloc_identity_pagetable() > again and again and again... Another method is read several bits at the front > of page to tell if the pagetable was setted up, but somehow tricky... > No, better to avoid tricks. But rmode_tss is only allocated once, so if you unify the allocations, the identity table will also only be allocated once. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone