From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Don't quit IO thread before all lvcpus stopped Date: Thu, 24 Apr 2008 19:14:02 +0300 Message-ID: <4810B1CA.1030909@qumranet.com> References: <1208990000.3374.20.camel@localhost.localdomain> <48108170.5090105@qumranet.com> <1209044138.3374.56.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: dor.laor@qumranet.com Return-path: In-Reply-To: <1209044138.3374.56.camel@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Dor Laor wrote: > On Thu, 2008-04-24 at 15:47 +0300, Avi Kivity wrote: > >> Dor Laor wrote: >> >>> while investigating the revert of "fix sci irq set when acpi timer" I >>> discovered the reason. Please also re-revert the original patch. >>> >>> >> Applied, but system_powerdown still doesn't work with the sci acpi timer >> fix. >> >> >> > > With the above patch and revert the reversion of "fix sci irq set when > acpi timer" it works for me. Can you give some details or try again? > > My host is 2.6.24.3-50-fc8, your kvm head (user > da00aa5090cf2de4259960ea659ac783bd65a041 + re-revert, kernel > 1736e3f0a3e173a7f452b32ad19bfff085a1a255). > Guest is winXp with acpi hal. After it boots I go to the monitor and > issue a system_powerdown. > Everything works and there is no segfaults (tested multiple time) > > With current master, Windows and Linux (FC6, x86_64) both shut down correctly after system_powerdown. With the sci timer thing re-applied, Windows continues to work but Linux no longer responds to ACPI powerdown. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone