Re: [PATCH] KVM x86: Handle hypercalls for assigned PCI devices

Amit Shah
2008-05-01T13:18:28Z

On Tuesday 29 April 2008 21:28:51 Amit Shah wrote:
> On Tuesday 29 April 2008 20:14:16 Glauber Costa wrote:
> > Amit Shah wrote:

> > > + if (find_pci_pt_dev(&vcpu->kvm->arch.pci_pt_dev_head,
> > > + &pci_pt_info, 0, KVM_PT_SOURCE_ASSIGN))
> > > + r++; /* We have assigned the device */
> > > +
> > > + kunmap(host_page);
> >
> > better use atomic mappings here.
>
> We can't use atomic mappings for guest pages. They can be swapped out.

Actually you were right: there's no sleeping call here after doing the
mapping. I've updated this call with kmap_atomic.

The other function that uses kmap can't be converted since we continue to map
several pages in a loop (depending on the length of the DMA region) and hence
can't use kmap_atomic there.

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.