From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: Protected mode transitions and big real
 mode...	still an issue
Date: Wed, 30 Apr 2008 02:20:56 +0300
Message-ID: <4817AD58.6020707@qumranet.com>
References: <20080429150236.70c51b02@frecb000711.frec.bull.fr>	<48174FC7.4060104@codemonkey.ws>
	<1209488968.4248.59.camel@frecb07144>
	<1209489733.4248.65.camel@frecb07144>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Rik van Riel <riel@surriel.com>,
	"kvm-devel@lists.sourceforge.net" <kvm-devel@lists.sourceforge.net>,
	Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>,
	Mohammed Gamal <m.gamal005@gmail.com>,
	Alexander Graf <alex@csgraf.de>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <1209489733.4248.65.camel@frecb07144>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Laurent Vivier wrote:
>> Why dst.val is not 0x53e10 ?
>>     
>
> I can answer myself to this one:
>
> 	emulate_2op_SrcB("sal", c->src, c->dst, ctxt->eflags);
>
> does nothing if dst.byte == 0
>
> So next question is the good question...
>
>   
>> Why dst.byte is 0 ?
>>
>>     

Because dst.bytes is only set if dst.type == OP_MEM, or ad hoc in the 
instruction itself.

Better to set it unconditionally (and adjust in the instruction if 
necessary).

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone