From: Avi Kivity <avi@qumranet.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [PATCH] kvm_show_code for ROM code
Date: Wed, 30 Apr 2008 20:51:22 +0300 [thread overview]
Message-ID: <4818B19A.20109@qumranet.com> (raw)
In-Reply-To: <481898F7.8040203@siemens.com>
Jan Kiszka wrote:
> Userland-located ROM memory is not available via kvm->physical_memory +
> guest_address. To let kvm_show_code also dump useful information when
> some problem in ROM (BIOS...) occurs, this patch first tries to obtain
> the memory content via the mmio_read callback - maybe not 100% clean,
> but works at least for the QEMU use case. If the callback complains
> about the given address, we then fall back to RAM access.
>
>
kvm->physical_memory is actually broken, since nothing guarantees a 1:1
(+offset) mapping.
Why not use ->mmio_read() all the time? Sure it overloads the
definition of mmio_read(), but worse things have happened.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-30 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 16:06 [PATCH] kvm_show_code for ROM code Jan Kiszka
2008-04-30 17:51 ` Avi Kivity [this message]
2008-05-02 8:44 ` Jan Kiszka
2008-05-02 9:44 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4818B19A.20109@qumranet.com \
--to=avi@qumranet.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox