From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm_show_code for ROM code Date: Fri, 02 May 2008 12:44:30 +0300 Message-ID: <481AE27E.1000706@qumranet.com> References: <481898F7.8040203@siemens.com> <4818B19A.20109@qumranet.com> <481AD47F.8000102@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jan Kiszka Return-path: In-Reply-To: <481AD47F.8000102@siemens.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Jan Kiszka wrote: > Userland-located memory is not unconditionally available via > kvm->physical_memory + guest_address. To let kvm_show_code also dump > useful information when, e.g., some problem in ROM (BIOS...) occurs, > this patch tries to obtain the memory content via the mmio_read > callback. If the callback fails, the code byte is marked as invalid. > > This patch also removes the check for protected mode and dumps the code > in any case - I didn't find the reason for this restriction. > > Applied, thanks. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone