* [PATCH] [ACPI] Enable _SUN in Slot devices
@ 2008-05-02 14:58 Alexander Graf
2008-05-07 10:21 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2008-05-02 14:58 UTC (permalink / raw)
To: kvm-devel
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi,
a patch recently introduced PCI device hotplugging. This added
pseudo-buses for every PCI slot, so that each device can be easily
ejected any time. The ACPI specification recommends the inclusion of a
_SUN entry in these though, to enable proper indexation of the slots.
Afaict Linux does not need this, but Darwin does.
This patch adds the corresponding _SUN entries to the PCI slot definitions.
Regards,
Alex
[-- Attachment #2: acpi-pcislots.patch --]
[-- Type: text/x-patch, Size: 7313 bytes --]
diff --git a/bios/acpi-dsdt.dsl b/bios/acpi-dsdt.dsl
index d2e33f4..f718b2e 100755
--- a/bios/acpi-dsdt.dsl
+++ b/bios/acpi-dsdt.dsl
@@ -426,6 +712,7 @@ DefinitionBlock (
Store(0x2, B0EJ)
Return (0x0)
}
+ Name (_SUN, 1)
}
Device (S2) { // Slot 2
@@ -434,6 +721,7 @@ DefinitionBlock (
Store(0x4, B0EJ)
Return (0x0)
}
+ Name (_SUN, 2)
}
Device (S3) { // Slot 3
@@ -442,6 +730,7 @@ DefinitionBlock (
Store (0x8, B0EJ)
Return (0x0)
}
+ Name (_SUN, 3)
}
Device (S4) { // Slot 4
@@ -450,6 +739,7 @@ DefinitionBlock (
Store(0x10, B0EJ)
Return (0x0)
}
+ Name (_SUN, 4)
}
Device (S5) { // Slot 5
@@ -458,6 +748,7 @@ DefinitionBlock (
Store(0x20, B0EJ)
Return (0x0)
}
+ Name (_SUN, 5)
}
Device (S6) { // Slot 6
@@ -466,6 +757,7 @@ DefinitionBlock (
Store(0x40, B0EJ)
Return (0x0)
}
+ Name (_SUN, 6)
}
Device (S7) { // Slot 7
@@ -474,6 +766,7 @@ DefinitionBlock (
Store(0x80, B0EJ)
Return (0x0)
}
+ Name (_SUN, 7)
}
Device (S8) { // Slot 8
@@ -482,6 +775,7 @@ DefinitionBlock (
Store(0x100, B0EJ)
Return (0x0)
}
+ Name (_SUN, 8)
}
Device (S9) { // Slot 9
@@ -490,6 +784,7 @@ DefinitionBlock (
Store(0x200, B0EJ)
Return (0x0)
}
+ Name (_SUN, 9)
}
Device (S10) { // Slot 10
@@ -498,6 +793,7 @@ DefinitionBlock (
Store(0x400, B0EJ)
Return (0x0)
}
+ Name (_SUN, 10)
}
Device (S11) { // Slot 11
@@ -506,6 +802,7 @@ DefinitionBlock (
Store(0x800, B0EJ)
Return (0x0)
}
+ Name (_SUN, 11)
}
Device (S12) { // Slot 12
@@ -514,6 +811,7 @@ DefinitionBlock (
Store(0x1000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 13)
}
Device (S13) { // Slot 13
@@ -522,6 +820,7 @@ DefinitionBlock (
Store(0x2000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 13)
}
Device (S14) { // Slot 14
@@ -530,6 +829,7 @@ DefinitionBlock (
Store(0x4000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 14)
}
Device (S15) { // Slot 15
@@ -538,6 +838,7 @@ DefinitionBlock (
Store(0x8000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 15)
}
Device (S16) { // Slot 16
@@ -546,6 +847,7 @@ DefinitionBlock (
Store(0x10000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 16)
}
Device (S17) { // Slot 17
@@ -554,6 +856,7 @@ DefinitionBlock (
Store(0x20000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 17)
}
Device (S18) { // Slot 18
@@ -562,6 +865,7 @@ DefinitionBlock (
Store(0x40000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 18)
}
Device (S19) { // Slot 19
@@ -570,6 +874,7 @@ DefinitionBlock (
Store(0x80000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 19)
}
Device (S20) { // Slot 20
@@ -578,6 +883,7 @@ DefinitionBlock (
Store(0x100000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 20)
}
Device (S21) { // Slot 21
@@ -586,6 +892,7 @@ DefinitionBlock (
Store(0x200000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 21)
}
Device (S22) { // Slot 22
@@ -594,6 +901,7 @@ DefinitionBlock (
Store(0x400000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 22)
}
Device (S23) { // Slot 23
@@ -602,6 +910,7 @@ DefinitionBlock (
Store(0x800000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 23)
}
Device (S24) { // Slot 24
@@ -610,6 +919,7 @@ DefinitionBlock (
Store(0x1000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 24)
}
Device (S25) { // Slot 25
@@ -618,6 +928,7 @@ DefinitionBlock (
Store(0x2000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 25)
}
Device (S26) { // Slot 26
@@ -626,6 +937,7 @@ DefinitionBlock (
Store(0x4000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 26)
}
Device (S27) { // Slot 27
@@ -634,6 +946,7 @@ DefinitionBlock (
Store(0x8000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 27)
}
Device (S28) { // Slot 28
@@ -642,6 +955,7 @@ DefinitionBlock (
Store(0x10000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 28)
}
Device (S29) { // Slot 29
@@ -650,6 +964,7 @@ DefinitionBlock (
Store(0x20000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 29)
}
Device (S30) { // Slot 30
@@ -658,6 +973,7 @@ DefinitionBlock (
Store(0x40000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 30)
}
Device (S31) { // Slot 31
@@ -666,6 +982,7 @@ DefinitionBlock (
Store(0x80000000, B0EJ)
Return (0x0)
}
+ Name (_SUN, 31)
}
Method (_CRS, 0, NotSerialized)
[-- Attachment #3: Type: text/plain, Size: 320 bytes --]
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
[-- Attachment #4: Type: text/plain, Size: 158 bytes --]
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [ACPI] Enable _SUN in Slot devices
2008-05-02 14:58 [PATCH] [ACPI] Enable _SUN in Slot devices Alexander Graf
@ 2008-05-07 10:21 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-05-07 10:21 UTC (permalink / raw)
To: Alexander Graf; +Cc: kvm-devel
Alexander Graf wrote:
> Hi,
>
> a patch recently introduced PCI device hotplugging. This added
> pseudo-buses for every PCI slot, so that each device can be easily
> ejected any time. The ACPI specification recommends the inclusion of a
> _SUN entry in these though, to enable proper indexation of the slots.
> Afaict Linux does not need this, but Darwin does.
>
> This patch adds the corresponding _SUN entries to the PCI slot
> definitions.
>
Patch looks fine; only missing a signoff.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-07 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-02 14:58 [PATCH] [ACPI] Enable _SUN in Slot devices Alexander Graf
2008-05-07 10:21 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox