Re: [PATCH 1/4] Only select once per-main_loop iteration

Avi Kivity
2008-05-04T13:03:21Z

Anthony Liguori wrote:
> QEMU is rather aggressive about exhausting the wait period when selecting.
> This is fine when the wait period is low and when there is significant delays
> in-between selects as it improves IO throughput.
>
> With the IO thread, there is a very small delay between selects and our wait
> period for select is very large. This patch changes main_loop_wait to only
> select once before doing the various other things in the main loop. This
> generally improves responsiveness of things like SDL but also improves
> individual file descriptor throughput quite dramatically.
>
> This patch is relies on my io-thread-timerfd.patch.
>

(did you mean signalfd?)

Patchset looks good; but as it depends on previous patches I can't apply
it yet.

--
error compiling committee.c: too many arguments to function