From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 1/4] Only select once per-main_loop iteration
Date: Sun, 04 May 2008 16:03:21 +0300 [thread overview]
Message-ID: <481DB419.8010804@qumranet.com> (raw)
In-Reply-To: <1209869233-17324-1-git-send-email-aliguori@us.ibm.com>
Anthony Liguori wrote:
> QEMU is rather aggressive about exhausting the wait period when selecting.
> This is fine when the wait period is low and when there is significant delays
> in-between selects as it improves IO throughput.
>
> With the IO thread, there is a very small delay between selects and our wait
> period for select is very large. This patch changes main_loop_wait to only
> select once before doing the various other things in the main loop. This
> generally improves responsiveness of things like SDL but also improves
> individual file descriptor throughput quite dramatically.
>
> This patch is relies on my io-thread-timerfd.patch.
>
(did you mean signalfd?)
Patchset looks good; but as it depends on previous patches I can't apply
it yet.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
prev parent reply other threads:[~2008-05-04 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 2:47 [PATCH 1/4] Only select once per-main_loop iteration Anthony Liguori
2008-05-04 2:47 ` [PATCH 2/4] Revert virtio tap hack Anthony Liguori
2008-05-04 4:03 ` Anthony Liguori
2008-05-04 8:01 ` Avi Kivity
2008-05-04 2:47 ` [PATCH 3/4] Make virtio-net can_receive more accurate Anthony Liguori
2008-05-04 2:47 ` [PATCH 4/4] Stop dropping so many RX packets in tap Anthony Liguori
2008-05-04 13:03 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481DB419.8010804@qumranet.com \
--to=avi@qumranet.com \
--cc=aliguori@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox