From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/4] Only select once per-main_loop iteration Date: Sun, 04 May 2008 16:03:21 +0300 Message-ID: <481DB419.8010804@qumranet.com> References: <1209869233-17324-1-git-send-email-aliguori@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Marcelo Tosatti To: Anthony Liguori Return-path: In-Reply-To: <1209869233-17324-1-git-send-email-aliguori@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > QEMU is rather aggressive about exhausting the wait period when selecting. > This is fine when the wait period is low and when there is significant delays > in-between selects as it improves IO throughput. > > With the IO thread, there is a very small delay between selects and our wait > period for select is very large. This patch changes main_loop_wait to only > select once before doing the various other things in the main loop. This > generally improves responsiveness of things like SDL but also improves > individual file descriptor throughput quite dramatically. > > This patch is relies on my io-thread-timerfd.patch. > (did you mean signalfd?) Patchset looks good; but as it depends on previous patches I can't apply it yet. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone